ref: Replace hardcoded booleans with named macros #223
+72
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
2 times, most recently
from
ab02e52 to
c0aaec7
Compare
|
@DavidMCerdeira looks good so far. Please let me know when its ready for final review |
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
from
c0aaec7 to
acf3c60
Compare
DavidMCerdeira
requested review from
AfonsoSantos96,
josecm and
ninolomata
as code owners
|
@josecm this is ready for review |
danielRep
approved these changes
Aug 6, 2025
This commit updates mainly memory and bitmap operations to use named macros like MEM_FREE_PAGES, MEM_PPAGES_ALIGNED, and BITMAP_SET instead of raw boolean values. Signed-off-by: David Cerdeira <[email protected]>
DavidMCerdeira
force-pushed
the
ref/avoid_bool_literals_invoke
branch
from
acf3c60 to
8784329
Compare
josecm
requested changes
Nov 6, 2025
Comment on lines
+74
to
+75
| #define VGIC_GICR_ACCESS true | ||
| #define VGIC_NO_GICR_ACCESS false |
There was a problem hiding this comment.
Shouldnt these macros have surrounding parentheses?
Suggested change
| #define VGIC_GICR_ACCESS true | |
| #define VGIC_NO_GICR_ACCESS false | |
| #define VGIC_GICR_ACCESS (true) | |
| #define VGIC_NO_GICR_ACCESS (false) |
Comment on lines
+74
to
+75
| #define VGIC_GICR_ACCESS true | ||
| #define VGIC_NO_GICR_ACCESS false |
There was a problem hiding this comment.
I'd prefer the phrasing:
Suggested change
| #define VGIC_GICR_ACCESS true | |
| #define VGIC_NO_GICR_ACCESS false | |
| #define VGIC_GICR_ACCESS true | |
| #define VGIC_NOT_GICR_ACCESS false |
Comment on lines
+58
to
+59
| #define MEM_PPAGES_ALIGNED true | ||
| #define MEM_PPAGES_NOT_ALIGNED false |
There was a problem hiding this comment.
Suggested change
| #define MEM_PPAGES_ALIGNED true | |
| #define MEM_PPAGES_NOT_ALIGNED false | |
| #define MEM_PPAGES_ALIGNED_REQUIRED true | |
| #define MEM_PPAGES_ALIGNED_NOT_REQUIRED false |
| #define MEM_DONT_BROADCAST false | ||
|
|
||
| #define MEM_LOCKED true | ||
| #define MEM_UNLOCKED false |
There was a problem hiding this comment.
Don't love the "unlocked" phrasing. To keep consistent with the other macros maybe MEM_NOT_LOCKED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates mainly memory and bitmap operations to use named macros like MEM_DONT_FREE_PAGES, MEM_ALIGN_PPAGES, and BITMAP_DONT_SET instead of raw boolean values on respective functions.